-
Notifications
You must be signed in to change notification settings - Fork 745
Feature: Migrate profile to simplechildwindow #3087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request introduces several updates to the Dialog Management Refactor:
UI Enhancements:
Validation Improvements:
Codebase Refinements:
Miscellaneous:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request migrates profile and group dialogs from the previous Metro dialog mechanism to using simple child windows. Key changes include replacing CustomDialog usage with ChildWindow components in XAML and updating the corresponding view model calls to use Application.Current.MainWindow for dialog hosting, as well as refactoring several asynchronous dialog invocations.
Reviewed Changes
Copilot reviewed 53 out of 54 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
ProfileDialogManager.cs | Migrates add/edit/copy/delete profile dialogs to use simple child windows instead of CustomDialogs. |
Various ViewModels (WhoisHostViewModel, WebConsoleHostViewModel, etc.) | Updates all profile dialog invocations to use Application.Current.MainWindow and refactors async calls. |
XAML files (e.g. ProfileChildWindow.xaml, MainWindow.xaml) | Adjusts layout/styling and binding to support the new simple child windows. |
Changes proposed in this pull request
Related issue(s)
To-Do
Contributing
By submitting this pull request, I confirm the following: